Fix localization crash on iOS 11 and 12 #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Style.localizeLabels(into:forLayerIds:) crashed on iOS 11 and 12 if any of the symbol layers had text-field set to nil. Fixes #954
|
Added a test that exercises the crash when run with the test host on an iOS 12 device and passes with the code change. |
evil159
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
I wonder if we should eliminate force unwrapping(lines 28 and 52) here to prevent these kinds of crashes happening in future. Nice thing about crashing is that they are more prominent to the SDK users, so they are more likely to report them. While thrown errors are more likely to be ignored.
|
@evil159 these are situations where we have complete control of the inputs, so if it throws, it's our fault and finding out about it through a crash seems reasonable to me. They don't seem like actionable errors to propagate to the public API. |
OdNairy
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Add 1tap Munich navigation scenario * Update new route file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any of the symbol layers had text-field set to nil.
Fixes #954
Pull request checklist:
## mainheading near the top).