Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return (-1, -1) if point for coordinate is out of map's bounds #1490

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

maios
Copy link
Contributor

@maios maios commented Jul 28, 2022

Fixes MAPSIOS-252
In MapboxMap.point(for:) if the coordinate is outside of map view's bounds it will return (-1, -1), however, when using MapboxMap.points(for:) it will return an actual coordinate. Based on @endanke's comment we should update MapboxMap.points(for) to also return (-1, -1) for coordinate that is outside of map view's bounds.

Pull request checklist:

  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Describe the changes in this PR, especially public API changes.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).

@maios maios requested a review from a team as a code owner July 28, 2022 08:01
@maios maios force-pushed the feature/MAPSIOS-252_point-outside-mapview branch from edf8b56 to ef6430f Compare July 28, 2022 13:05
@maios maios merged commit 52b7697 into main Jul 28, 2022
@maios maios deleted the feature/MAPSIOS-252_point-outside-mapview branch July 28, 2022 13:44
OdNairy added a commit that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants