Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mapsios 271 puck 3d default scale #1523

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Feature/mapsios 271 puck 3d default scale #1523

merged 3 commits into from
Aug 12, 2022

Conversation

maios
Copy link
Contributor

@maios maios commented Aug 11, 2022 •
edited
Loading

Apply mercator scale when modelScale is nil (assuming it will be [1, 1, 1])

Pull request checklist:

  • Describe the changes in this PR, especially public API changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@maios
Apply mercator scale to puck 3D also when its modelScale is not set.
d8815ae 
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
@maios
Update unit tests
73c2b7b
@maios maios requested a review from a team as a code owner August 11, 2022 06:40
evil159
evil159 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@evil159 evil159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a changelog entry for this fix 👍

@maios maios merged commit 42d0a7c into main Aug 12, 2022
@maios maios deleted the feature/MAPSIOS-271_puck-3d-default-scale branch August 12, 2022 08:38
yunikkk pushed a commit that referenced this pull request Aug 24, 2022
@maios @yunikkk
Feature/mapsios 271 puck 3d default scale (#1523) (#1531)
bcd97c7 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
yunikkk pushed a commit that referenced this pull request Aug 24, 2022
@maios @yunikkk
Feature/mapsios 271 puck 3d default scale (#1523) (#1531)
cc665ad 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
yunikkk pushed a commit that referenced this pull request Aug 24, 2022
@maios @yunikkk
Feature/mapsios 271 puck 3d default scale (#1523) (#1531)
7f8bb11 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
yunikkk pushed a commit that referenced this pull request Aug 24, 2022
@maios @yunikkk
Feature/mapsios 271 puck 3d default scale (#1523) (#1531)
17174e1 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
yunikkk pushed a commit that referenced this pull request Aug 24, 2022
@maios @yunikkk
Feature/mapsios 271 puck 3d default scale (#1523) (#1531)
d29fc63 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
yunikkk pushed a commit that referenced this pull request Aug 24, 2022
@maios @yunikkk
Feature/mapsios 271 puck 3d default scale (#1523) (#1531)
8870c70 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
OdNairy pushed a commit that referenced this pull request Aug 24, 2022
@maios @OdNairy
Feature/mapsios 271 puck 3d default scale (#1523)
6abcf97 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
kushsolitary pushed a commit to supersonic-club/mapbox-maps-ios that referenced this pull request Sep 14, 2022
@maios
Feature/mapsios 271 puck 3d default scale (mapbox#1523) (mapbox#1531)
32ade84 
* Apply mercator scale to puck 3D also when its modelScale is not set.
- When a modelScale is not set, assume it is [1,1,1] (real size) and apply mercator scale for it.
mapbox-github-ci-writer-public-1 bot pushed a commit that referenced this pull request Aug 2, 2023
@OdNairy
Bump Xcode version to 14.1 (#1523)
60acce0 
* Update executor version

* Replace xcode-min executor with xcode-sdk-min

* Enforce xcode-sdk-min executor

* Update device model for builds

* Drop XcodeGen xcode versions

* Fix

* Remove outdated breakage list data

* Add new detections for breaking APIs

* Fix benchmark flow

* Increase timeouts for AttributionTests

* Re-enable bitcode
OdNairy added a commit that referenced this pull request Aug 22, 2023
@OdNairy
Bump Xcode version to 14.1 (#1523)
3126f68 
* Update executor version

* Replace xcode-min executor with xcode-sdk-min

* Enforce xcode-sdk-min executor

* Update device model for builds

* Drop XcodeGen xcode versions

* Fix

* Remove outdated breakage list data

* Add new detections for breaking APIs

* Fix benchmark flow

* Increase timeouts for AttributionTests

* Re-enable bitcode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evil159 evil159 evil159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maios @evil159