Fix static linking cocoapods #1888
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1888 +/- ##
==========================================
- Coverage 89.31% 89.25% -0.06%
==========================================
Files 243 243
Lines 15174 15183 +9
==========================================
- Hits 13552 13551 -1
- Misses 1622 1632 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| m.resources = ['Sources/**/*.{xcassets,strings}', 'Sources/MapboxMaps/MapboxMaps.json'] | ||
| m.resource_bundles = { 'MapboxMapsResources' => ['Sources/**/*.{xcassets,strings}', 'Sources/MapboxMaps/MapboxMaps.json'] } | ||
|
|
||
| # Xcode 14.x throws an error about code signing on resource bundles, turn it off for now. |
There was a problem hiding this comment.
Let's add a TODO to remove this when cocoapods 1.12 is released, they fixed this issue CocoaPods/CocoaPods#11723
| return Bundle(for: BundleLocator.self) | ||
| // When using frameworks this bundle will be our `.framework` bundle. | ||
| // When using static linking this bundle will be the the host application's `.app` bundle. | ||
| let bundle = Bundle(for: BundleLocator.self) |
There was a problem hiding this comment.
Basically, this bundle will be used only for binary distribution, right?
I mean, for spm the module bundle will be used, for cocoapods, it will be the MapboxMapsResources.bundle, but for binary distribution we still need BundleLocator.
|
HI Team, Could you please help me to build iOS using azure devops pipelines with two provisioning profiles, build is getting succeeded but when trying to install the IPA file in iOS device it is getting crashed. Same code is working in local machine with Xcode 14.2 |
This PR is based on #1759:
Additionally code signing is disabled for Cocoapods distribution pending Cocoapods issue CocoaPods/CocoaPods#11402 to be included in the upcoming release.