Move options for ornaments into individual structs #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#307) * Expose computed vars for operators + arguments of expressions * Support string based arrays as valid expression argument * Refactor ExpressionBuilder * review comment * cleanup Remove check for iOS 11 Update LogoView to make class and properties internal Update OrnamentsManager.options documentation Updated the changelog Remove options parameter from MapConfig.setupOrnaments() Updated changelog to note that MapView.update no longer used for ornaments
jmkiley
added
the
breaking change ⚠️
neelmistry94
reviewed
May 5, 2021
| /// The default value for this property is `CGPoint(x: 8.0, y: 8.0)`. | ||
| public var margins: CGPoint = defaultOrnamentsMargin | ||
| /// The default value for this property is `.adaptive`. | ||
| public var visibility: OrnamentVisibility = .adaptive |
There was a problem hiding this comment.
Looks like visibility is consistent as a property, we should add that as part of the BaseOrnamentOptions protocol
neelmistry94
reviewed
May 5, 2021
| /// The default value for this property is `CGPoint(x: 8.0, y: 8.0)`. | ||
| public var margins: CGPoint = defaultOrnamentsMargin | ||
| /// The default value for this property is `true`. | ||
| public var _isVisible: Bool = true |
There was a problem hiding this comment.
why don't we use OrnamentVisibility here and make it conform to BaseOrnamentOptions
There was a problem hiding this comment.
I think we originally used a BOOL here because these two ornaments wouldn't ever have .adaptive visibility.
There was a problem hiding this comment.
But we can control that right? Should the user not be allowed to change that configuration?
There was a problem hiding this comment.
Maybe we can label that as tailwork, since it may require more discussion.
neelmistry94
reviewed
May 5, 2021
| /// The default value for this property is `CGPoint(x: 8.0, y: 8.0)`. | ||
| public var margins: CGPoint = defaultOrnamentsMargin | ||
| /// The default value for this property is `true`. | ||
| public var _isVisible: Bool = true |
There was a problem hiding this comment.
Same comment as AttributionButtonOptions
neelmistry94
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ioschangelog:<changelog></changelog>.Summary of changes
This PR breaks the different ornament options into separate structs, which are then accessed via properties on OrnamentOptions. Therefore,
OrnamentOptions.scaleBarVisibilitybecomesOrnamentOptions.scaleBar.visibility.User impact (optional)