Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MapView][Part 2] Make LocationManager hold LocationOptions directly #344

Merged
merged 1 commit into from
May 14, 2021

Conversation

nishant-karajgikar
Copy link
Contributor

@nishant-karajgikar nishant-karajgikar commented May 13, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

LocationManager now holds the LocationOptions directly similar to gestures.

The call site is now:

mapView.location.options.puckType = .puck2D()

@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/collapse-location-options branch 2 times, most recently from 02e0880 to 7d3cfef Compare May 13, 2021 13:51
@nishant-karajgikar nishant-karajgikar added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label May 13, 2021
Base automatically changed from nishantk/collapse-gesture-options to main May 14, 2021 16:33
@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/collapse-location-options branch 2 times, most recently from b964ff4 to e71e8e0 Compare May 14, 2021 16:37
@nishant-karajgikar nishant-karajgikar force-pushed the nishantk/collapse-location-options branch from e71e8e0 to 0adf9c7 Compare May 14, 2021 16:38
@nishant-karajgikar nishant-karajgikar merged commit 8e8298d into main May 14, 2021
@nishant-karajgikar nishant-karajgikar deleted the nishantk/collapse-location-options branch May 14, 2021 16:44
jmkiley pushed a commit that referenced this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants