-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make __map private #374
Merged
Merged
Make __map private #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5947896
to
c70a232
Compare
[run device tests]
[run device tests]
This reverts commit 77d7e0c. [run device tests]
[run device tests]
[run device tests]
[run device tests]
[run device tests]
[run device tests]
[run device tests] [run app device tests]
[run device tests] [run app device tests]
837627e
to
856ea54
Compare
[run device tests]
neelmistry94
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ⚠️
If your pull request introduces a breaking change and updates are required when version is published
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ios
changelog:<changelog></changelog>
.Summary of changes
MapboxMap.__map
privateCameraManagerProtocol .setCameraBounds
MapboxMap.prefetchZoomDelta
MapboxMap.options
to return the currentMapOptions
MapboxMap.reduceMemoryUse()
MapboxMap.resourceOptions
MapboxMap.elevation(at:)
OfflineError.invalidResult
andOfflineError.typeMismatch
In the MapboxMaps Xcode project, MapboxMaps is built as a dynamic framework, including its dependencies using SPM. These end up as sub-frameworks when built, which AWS Device Farm does not appear to re-code-sign. Prior to upload these sub-frameworks are moved to being child frameworks of the test host application.
Attempting to add the dependencies to the host application results in an error regarding "duplicated code" even though these are dynamic frameworks. This appears to be a known issue. Explicitly marking the dependencies as dynamic may solve this issue.