Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make __map private #374

Merged
merged 15 commits into from
May 25, 2021
Merged

Make __map private #374

merged 15 commits into from
May 25, 2021

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented May 20, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

  • Made MapboxMap.__map private
  • Update CircleCI to use derived data directory for MapboxMaps xcodeproj testing
  • Re-enable code coverage (except for codecov.io)
  • Added
    • CameraManagerProtocol .setCameraBounds
    • MapboxMap.prefetchZoomDelta
    • MapboxMap.options to return the current MapOptions
    • MapboxMap.reduceMemoryUse()
    • MapboxMap.resourceOptions
    • MapboxMap.elevation(at:)
  • Removed OfflineError.invalidResult and OfflineError.typeMismatch

In the MapboxMaps Xcode project, MapboxMaps is built as a dynamic framework, including its dependencies using SPM. These end up as sub-frameworks when built, which AWS Device Farm does not appear to re-code-sign. Prior to upload these sub-frameworks are moved to being child frameworks of the test host application.

Attempting to add the dependencies to the host application results in an error regarding "duplicated code" even though these are dynamic frameworks. This appears to be a known issue. Explicitly marking the dependencies as dynamic may solve this issue.

@julianrex julianrex marked this pull request as ready for review May 24, 2021 23:04
@julianrex julianrex added the breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published label May 24, 2021
@julianrex julianrex merged commit 904fd65 into main May 25, 2021
@julianrex julianrex deleted the jrex/private-map branch May 25, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ⚠️ If your pull request introduces a breaking change and updates are required when version is published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants