Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing camera methods to Snapshotter #386

Merged
merged 4 commits into from
May 24, 2021
Merged

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented May 24, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-ios changelog: <changelog></changelog>.
  • Update the migration guide, API Docs, Markdown files - Readme, Developing, etc

Summary of changes

This PR adds 2 camera methods to Snapshotter to align with Android:

func coordinateBounds(for camera: CameraOptions) -> CoordinateBounds

func camera(for coordinates: [CLLocationCoordinate2D],
                       padding: UIEdgeInsets,
                       bearing: Double?,
                       pitch: Double?) -> CameraOptions

/cc @kiryldz

@julianrex julianrex added the feature 🍏 When working on a new feature or feature enhancement label May 24, 2021
Copy link
Contributor

@neelmistry94 neelmistry94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly nits

@julianrex julianrex enabled auto-merge (squash) May 24, 2021 17:51
@julianrex julianrex merged commit a3783be into main May 24, 2021
@julianrex julianrex deleted the jrex/snapshotter-camera branch May 24, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🍏 When working on a new feature or feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants