Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete GeoJSONManager #603

Merged
merged 2 commits into from
Aug 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@ Mapbox welcomes participation and contributions from everyone.

## main

### Breaking changes ⚠️

* Removed GeoJSONManager. Please use Turf directly instead to serialize and deserialize GeoJSON. ([#603](https://github.com/mapbox/mapbox-maps-ios/pull/603))

### Bug fixes 🐞

* Update all Annotation files to use `get/set` instead of `didSet`. This fixes an issue where properties were not being set at `init`. ([#590](https://github.com/mapbox/mapbox-maps-ios/pull/590))

## 10.0.0-rc.6 - August 11, 2021
Expand Down Expand Up @@ -54,9 +59,6 @@ Mapbox welcomes participation and contributions from everyone.
* Fixed an issue that could cause flickering during ease to and basic animations ([#519](https://github.com/mapbox/mapbox-maps-ios/pull/519))
* Fixed an issue that could result in ease to and basic animations never reaching their final values ([#519](https://github.com/mapbox/mapbox-maps-ios/pull/519))




## 10.0.0-rc.3 - June 30, 2021

### Features ✨ and improvements 🏁
Expand Down
53 changes: 0 additions & 53 deletions Sources/MapboxMaps/Foundation/GeoJSONManager.swift

This file was deleted.

6 changes: 3 additions & 3 deletions Sources/MapboxMaps/Style/Style.swift
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,9 @@ public class Style {
sourceInfo.type == .geoJson else {
fatalError("updateGeoJSONSource: Source with id '\(id)' is not a GeoJSONSource.")
}

let geoJSONDictionary = try GeoJSONManager.dictionaryFrom(geoJSON)
try setSourceProperty(for: id, property: "data", value: geoJSONDictionary as Any)
let data = try JSONEncoder().encode(geoJSON)
let value = try JSONSerialization.jsonObject(with: data)
try setSourceProperty(for: id, property: "data", value: value)
}

// MARK: - Light
Expand Down
142 changes: 0 additions & 142 deletions Tests/MapboxMapsTests/Foundation/GeoJSON/GeoJSONManagerTests.swift

This file was deleted.