Update Core and Common #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
added
bug 🪲
macdrevx
requested review from
neelmistry94 and
nishant-karajgikar
and removed request for
neelmistry94
macdrevx
force-pushed
the
update_dependencies_for_CoreCommon
branch
from
0a5c5b9
to
d4af6da
Compare
macdrevx
force-pushed
the
update_dependencies_for_CoreCommon
branch
from
d4af6da
to
0d0807c
Compare
| @@ -531,7 +531,7 @@ public class PointAnnotationManager: AnnotationManager { | |||
| switch result { | |||
|
|
|||
| case .success(let queriedFeatures): | |||
| if let annotationIds = queriedFeatures.compactMap(\.feature.properties["annotation-id"]) as? [String] { | |||
| if let annotationIds = queriedFeatures.compactMap({ $0.feature?.properties?["annotation-id"] }) as? [String] { | |||
There was a problem hiding this comment.
were these changes propagated from stylegen?
neelmistry94
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #626
Pull request checklist:
Summary of changes
Updates Core and Common