Gesture Options Cleanup #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
added
bug 🪲
macdrevx
requested review from
nishant-karajgikar,
neelmistry94 and
jmkiley
| /// A constant factor that determines how quickly pan deceleration animations happen. | ||
| /// Multiplied with the velocity vector once per millisecond during deceleration animations. | ||
| /// Defaults to `UIScrollView.DecelerationRate.normal.rawValue` | ||
| public var panDecelerationFactor: CGFloat = UIScrollView.DecelerationRate.normal.rawValue |
There was a problem hiding this comment.
everywhere else in the code, this has been called decelerationFactor. Why is it that the options have a prepended pan in front of it?
There was a problem hiding this comment.
We want to indicate that this setting only applies to pan. In the other locations, the meaning is clear from the context. Later, we might add other separate deceleration factor options for other gestures, so the prefix sets us up to be able to do that in an additive way.
| case doubleTapToZoomIn | ||
|
|
||
| /// The double touch to zoom out gesture | ||
| case doubleTouchToZoomOut |
There was a problem hiding this comment.
nit: Let's order these alphabetically
There was a problem hiding this comment.
Can we debate this in a separate ticket?
neelmistry94
approved these changes
Sep 22, 2021
Comment on lines
-66
to
-68
| self.initialTouchLocation = nil | ||
| self.initialCameraState = nil | ||
| self.lastChangedDate = nil |
There was a problem hiding this comment.
Should we make this completion optional? Seems like it should be nullable instead of sending an empty closure here.
There was a problem hiding this comment.
let's address this in a future pr.
nishant-karajgikar
force-pushed
the
feature/gestures_cleanup
branch
from
ad05bdb
to
5fdc54d
Compare
nishant-karajgikar
force-pushed
the
ah/gesture-options
branch
from
c40d056
to
6409cca
Compare
Merged
nishant-karajgikar
added a commit
that referenced
this pull request
Sep 22, 2021
* remove hapticFeedbackEnabled (#663) * remove hapticFeedbackEnabled` * clean up changelog * Make gestureOptions.decelarationRate the source of truth (#662) * making gesture options decelaration rate the source of truth * clean up changelog * fix indentation * Internalize UIGestureRecognizerDelegate (#669) * seperated gesture recognizer delegate into a new class and fixed downstream breaks * adding changelog * swift lint and code clean up * adding a comment * pr comments * Refactor gestures (#677) #### Breaking Changes - Pan deceleration has been temporarily removed - `TapGestureHandler.init` was previously public by mistake and is now internal - The behavior of `GestureManager.options` has been updated to better reflect the `isEnabled` state of the associated gesture recognizers - The gesture recognizer properties of `GestureManager` are no longer `Optional` - `GestureType` has been redesigned so that its cases have a 1-1 relationship with the built-in gestures #### Public API Additions - `CameraState`'s fields are now `var`s instead of `let`s for testing purposes, and a public, memberwise initializer has been added. - `PanScrollingMode` now conforms to `CaseIterable` - `GestureType` now conforms to `CaseIterable` #### Bug fixes - GestureManager no longer sets itself as the delegate of all gestures in MapView when its options change #### Internal Refactoring - Generalizes `CameraAnimatorMapboxMap` by renaming it to `MapboxMapProtocol` so that it can be used throughout the SDK. SDK seems small enough that per-component dependency inversion feels unnecessary and might negatively impact binary size. - Removes old `GestureHandlerDelegate` by injecting `MapboxMap` and `CameraAnimationsManager` into each gesture handler to allow each handler to manipulate the camera directly. - Removes unnecessary `GestureContextProvider` - Refactors handlers and `GestureManager` for dependency injection and more thorough tests - Tidies up handlers and `GestureManager` and associated tests for greater consistency * Pan Deceleration (#692) * update changelog * fix changelog * Gesture Options Cleanup (#696) * wip * Change double tap to zoom out to "double touch" * Fix warning * Lint * Update changelog * [run device tests] * Use explicit self Co-authored-by: Andrew Hershberger <andrew.hershberger@mapbox.com> Co-authored-by: Nishant Karajgikar <nishant.karajgikar@mapbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
Summary of changes
Breaking changes
GestureManager.rotationGestureRecognizerhas been removed. Rotation is now handled by.pinchGestureRecognizerin addition to its preexisting handling of panning and zooming.GestureManager.doubleTapToZoomOutGestureRecognizerhas been replaced with.doubleTouchToZoomOutGestureRecognizerPanScrollingModehas been renamed toPanModeGestureOptions.zoomEnabledhas been replaced by.doubleTapToZoomInEnabled,.doubleTouchToZoomOutEnabled, and.quickZoomEnabledGestureOptions.rotateEnabledhas been removedGestureOptions.scrollEnabledhas been renamed to.panEnabledGestureOptions.scrollingModehas been renamed to.panModeGestureOptions.decelerationRatehas been renamed to.panDecelerationFactorGestureType.doubleTapToZoomOuthas been replaced with.doubleTouchToZoomOutGestureType.rotatehas been removedGestureTypecases have been reordered for consistency withGestureOptionsandGestureManagerBug Fixes