Lock out animations during any touch events #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
added
the
skip changelog
…transfer comments from internal protocols; rename setCameraBounds(for:) to setCameraBounds(with:)
macdrevx
force-pushed
the
ah/animation-lockout
branch
from
12f9b26
to
85e9001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #645
Pull request checklist:
Summary of changes
Update animation cancellation logic for gestures to prevent all camera animations while there are active touches on the map.
No public API changes.
Also includes some light refactoring of ornaments to eliminate the
OrnamentSupportableViewprotocol