[map] Expose presentsWithTransaction inside RenderOptions #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant-karajgikar
added
the
feature 🍏
julianrex
approved these changes
Feb 11, 2021
|
|
||
| // Set prefetch zoom delta | ||
| let defaultPrefetchZoomDelta: UInt8 = 4 | ||
| try! self.__map.setPrefetchZoomDeltaForDelta(self.mapOptions.prefetchesTiles ? defaultPrefetchZoomDelta : 0) | ||
| try! self.__map.setPrefetchZoomDeltaForDelta(renderOptions.prefetchesTiles ? defaultPrefetchZoomDelta : 0) |
There was a problem hiding this comment.
Reminder to self: we should just support an arbitrary zoom delta here.
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Make default modelScaleMode of Puck3D to ModelScaleMode.viewport. - Remove implemetation of applying default modelScale expression. * Apply default modelScale to [10, 10, 10] Co-authored-by: Mai Mai <mai.mai@mapbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Pull request checklist:
mapbox-maps-ioschangelog:<changelog>ExposepresentsWithTransactionproperty to better synchronize UIKit elements with theMapView.</changelog>.Summary of changes
This PR exposes the
presentsWithTransactionproperty of the underlyingmetalViewthat is being used to render the map.Additionally, it moves all rendering-related options into a new
RenderOptionsstruct which follows the same semantics as the other configuration options.User impact (optional)
Use the
mapView.updatemethod to update the render options like so: