Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify NavigationCamera#resume values #658

Closed
1 of 3 tasks
sarahsnow1 opened this issue Jan 19, 2018 · 2 comments
Closed
1 of 3 tasks

Verify NavigationCamera#resume values #658

sarahsnow1 opened this issue Jan 19, 2018 · 2 comments

Comments

@sarahsnow1
Copy link
Contributor

What kind of issue is this?

  • Question. This issue tracker is not the place for questions. If you want to ask how to do something, or to understand why something isn't working the way you expect it to, use Stack Overflow. https://stackoverflow.com/questions/tagged/mapbox+android

  • Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests get fixed. In addition, please include device models, API level, SDK version, code samples, and any other additional information.
    While implementing Update Default Zoom Level #655 I noticed that NavigationCamera#resume was being triggered without the device rotating. Maybe this is the correct behavior and the javadocs are outdated or there is a bug?

  • Feature Request. Start by telling us what problem you’re trying to solve. Often a solution already exists! Don’t send pull requests to implement new features without first getting our support. Sometimes we leave features out on purpose to keep the project small.

@danesfeder
Copy link
Contributor

@sarahlensing Thanks for the report and yes NavigationCamera#resume should only be triggered after rotation. When it was being triggered unexpectedly, were you able to tell if it was from every location update? We have a flag to ensure it isn't, but I'm wondering if this is getting out of sync somehow.

@Guardiola31337
Copy link
Contributor

#679 addressed this an added tests.

We're good here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants