Prevent NavigationNotification update after unregistered #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danesfeder this would only fix the first crash reported in #1116 right? |
I've just 👀 #1116 (comment) Thanks @danesfeder 🙏 |
danesfeder
force-pushed
the
dan-notification-register
branch
from
ef8ecec
to
ba02ce6
Compare
Tracking in #1119 |
Guardiola31337
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Added a minor comment (not blocking the PR).
Thanks @danesfeder
| @@ -8,6 +8,7 @@ | |||
| class NavigationNotificationProvider { | |||
|
|
|||
| private NavigationNotification navigationNotification; | |||
| private boolean isUpdating = true; | |||
There was a problem hiding this comment.
NIT - what about shouldUpdate instead? It sounds better to me. By default, shouldUpdate? Yes - true After shutting down, shouldUpdate? No - false
What do you think?
danesfeder
force-pushed
the
dan-notification-register
branch
from
ba02ce6
to
2b233bc
Compare
danesfeder
force-pushed
the
dan-notification-register
branch
from
2b233bc
to
3a70d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1116 Regression from #1066
Added a boolean to prevent notification updates after the notification has been shut down.