Remove navigation listeners before clearing NavigationEngineFactory #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139
Clearing the engines in
NavigationEngineFactoryshould be the last thing we do when shutting down inonDestroy(after we remove listeners as well) https://github.com/mapbox/mapbox-navigation-android/compare/dan-off-route-npe?expand=1#diff-667eeafdcc4161cea7ec77c7be674b6fR215This way, it's not possible for updates to query the engines because the listeners are already removed before we clear the engines. This PR also adds logic to ignore null engines in
NavigationEngineFactory.