Update MapRouteProgressChangeListener to be aware of route visibility #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-progress-route
branch
from
1bca8cb
to
67f422f
Compare
Guardiola31337
approved these changes
Oct 31, 2018
|
@danesfeder when will this be in a stable release? |
|
@Danny-James look for a release this week |
|
@danesfeder Thank You 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1293
The
MapRouteProgressChangeListenerwas immediately re-drawing the route after removal with the next progress update. It should be aware of the current state ofNavigationMapRouteand ignore updates if the current route isn't visible.