Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ManeuverModifier and rely on the one exposed in MAS #2970

Merged
merged 1 commit into from May 13, 2020

Conversation

Guardiola31337
Copy link
Contributor

Description

Removes ManeuverModifier and rely on the one exposed in MAS mapbox-sdk-directions-models after bumping mapbox-sdk-services and mapbox-sdk-directions-models dependency versions to 5.2.1

Follow up from https://github.com/mapbox/mapbox-navigation-android/pull/2839/files#diff-8c755921f2385f1530835cba285cbdceL276-L309 and mapbox/mapbox-java#1141

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

General clean up

Implementation

Replace ManeuverModifier occurrences by MAS ones

Testing

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

…rections-models after bumping mapbox-sdk-services and mapbox-sdk-directions-models dependency versions to 5.2.1
@Guardiola31337 Guardiola31337 merged commit f4107e1 into master May 13, 2020
@Guardiola31337 Guardiola31337 deleted the pg-remove-maneuver-modifier branch May 13, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants