Separating the functionality of the previous distance formatter to ma… #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafesilencio
added
the
skip changelog
cafesilencio
force-pushed
the
sb-5605-distance-formatter
branch
2 times, most recently
from
519d83e
to
3895d86
Compare
|
Code wise this is looking good. I have a question. From #5065
I saw we opted to expose it through the new |
|
Part of my reasoning was to maintain backward compatibility and avoid breaking semver. The new implementation will support the Nav. SDK as well as the Android Auto implementation. |
abhishek1508
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
LGTM. Let's add a changelog since the PR introduces new API using MapboxDistanceUtil.
/cc @cafesilencio
RingerJK
reviewed
Dec 14, 2021
| * @param distanceSuffix a suffix that goes with the string value of the distance like 'km' for kilometers, 'ft' for foot/feet, 'mi' for miles etc. depending on the Locale and the UnitType | ||
| * @param unitType indicates if the values represented are metric or imperial | ||
| */ | ||
| data class FormattedDistanceData( |
There was a problem hiding this comment.
should be internal constructor? if so need to remove data and override quals/toString/hashCode
cafesilencio
force-pushed
the
sb-5605-distance-formatter
branch
from
3895d86
to
516f406
Compare
cafesilencio
removed
the
skip changelog
cafesilencio
force-pushed
the
sb-5605-distance-formatter
branch
from
516f406
to
e90a411
Compare
…ke it more usable by components that need a less opinionated formatter.
cafesilencio
force-pushed
the
sb-5605-distance-formatter
branch
from
e90a411
to
27b459d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses what is described in #5065 by refactoring the formatter related code so that the rounding calculations are decoupled from the formatting of the text used in the display. Backwards compatibility is maintained. In addition the new implementation should be usable by the Android Auto implementation which is one of the goals.
Changelog
Screenshots or Gifs