Directions API Banner instructions #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
feature
2 tasks
danesfeder
force-pushed
the
dan-banner-instruction
branch
7 times, most recently
from
c7cfd4a
to
7268b73
Compare
danesfeder
force-pushed
the
dan-banner-instruction
branch
2 times, most recently
from
3928870
to
d44cb69
Compare
|
|
|
@cammace @Guardiola31337 this PR is good for 👀 now - only thing that needs to land before we merge is |
danesfeder
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
danesfeder
force-pushed
the
dan-banner-instruction
branch
2 times, most recently
from
909c4a1
to
35adb03
Compare
cammace
approved these changes
Jan 12, 2018
| @@ -69,6 +69,9 @@ dependencies { | |||
| // AWS Polly | |||
| implementation dependenciesList.polly | |||
|
|
|||
| // Picasso | |||
| implementation dependenciesList.picasso | |||
There was a problem hiding this comment.
If we are using Picasso for one specific use case, it might be better just handling image loading ourselves to eliminate an additional dependency. Otherwise, I do think Picasso is one of the smallest image loading SDKs out there.
danesfeder
force-pushed
the
dan-banner-instruction
branch
from
35adb03
to
1cfce58
Compare
|
@ericrwolfe updated with correct |
danesfeder
force-pushed
the
dan-banner-instruction
branch
from
1477b0b
to
c7d1a42
Compare
danesfeder
force-pushed
the
dan-banner-instruction
branch
from
396c97e
to
1f144e7
Compare
danesfeder
force-pushed
the
dan-banner-instruction
branch
from
1f144e7
to
b9b5a00
Compare
TranThuong
pushed a commit
to TranThuong/mapbox-navigation-android
that referenced
this pull request
Jan 26, 2018
* master: Update Strings with Transifex Translations (mapbox#657) Added embedded navigation example (mapbox#654) Release 0.9.0 (mapbox#663) Update README.md for 0.9.0 (mapbox#664) Add Maneuver type exit rotary constant (mapbox#653) Update Maps and Services dependencies (mapbox#661) Add FasterRouteDetector to check for quicker routes while navigating (mapbox#638) Directions API Banner instructions (mapbox#582) NavigationTelemetry update cue for changing configurations (mapbox#648) Moved WaypointNavigationActivity from the SDK to the test app (mapbox#652) Exposes the MapboxMap in NavigationView with a getter method (mapbox#642) Add language to NavigationViewOptions with default from RouteOptions (mapbox#635) # Conflicts: # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationEngine.java # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationService.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstructionViewBannerInstructionMilestoneto provideMilestoneupdates along the route (similar to how we fire voice announcements)cc @ericrwolfe