Update Metalava #5883
Merged
Update Metalava #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
added
Core
Guardiola31337
commented
Jun 1, 2022
scripts/update_metalava.sh
Outdated
Comment on lines
19
to
23
| # Dev branch has JAVA_HOME defined in the project, if building from development branches, | ||
| # uncomment below to exclude JAVA_HOME export and use JAVA_HOME from local machine. | ||
| # sed '/^export JAVA_HOME=/d' gradlew > gradlew.temp | ||
| # mv gradlew.temp gradlew | ||
| # chmod a+x gradlew |
There was a problem hiding this comment.
$> make update-metalava was failing because of ^^ cc @RingerJK @LukasPaczos
This was referenced Jun 1, 2022
RingerJK
reviewed
Jun 1, 2022
scripts/update_metalava.sh
Outdated
|
|
||
| # Pick the release tag you prefer, | ||
| # more detailed tags/versions can be found at https://android.googlesource.com/platform/tools/metalava/+refs | ||
| git checkout android-12.1.0_r5 |
There was a problem hiding this comment.
that what I was looking for 👍
RingerJK
approved these changes
Jun 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #5883 +/- ##
=========================================
Coverage 67.55% 67.55%
Complexity 3877 3877
=========================================
Files 591 591
Lines 23844 23844
Branches 2747 2747
=========================================
Hits 16108 16108
Misses 6709 6709
Partials 1027 1027 |
I run into the same issue locally 🤔 I think it has to be with the system version of Java. I'm investigating ⛏️ |
Guardiola31337
force-pushed
the
pg-update-metalava
branch
from
5974d2e
to
e7650cd
Compare
Guardiola31337
force-pushed
the
pg-update-metalava
branch
from
e7650cd
to
68a9625
Compare
After some fighting I was able to update to latest Metalava ( |
|
Going ahead and merging here 🚀 |
kmadsen
reviewed
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Metalava
Closes #5852