Add onDestroy as a method that must be implemented for NavigationView #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
approved these changes
Jan 6, 2018
|
Love it. Thanks @danesfeder |
danesfeder
force-pushed
the
dan-ondestroy
branch
from
47dee1f
to
c36833b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using the
NavigationViewin aFragmentimplementation, theMapViewis not properly destroyed.This is because the we are using the
Activitycontext to look for the onDestroy lifecycle event using the new architecture components.In a
Fragment,MapView#onDestroyneeds to be called inFragment#onDestroyView. This PR re-exposes the lifecycle method to allow developers to do this.cc @ericrwolfe @tobrun @langsmith