route progress test added #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
added
ready for review
and removed
⚠️ DO NOT MERGE
|
This PR adds a bunch of test and fixes up the RouteProgress classes (cleaned up code and fixed minor bugs). @zugaldia can you review? |
|
@cammace I believe you were gonna introduce some changes to this PR (deltas vs rounding). Let me know when that lands and happy to 👀 the PR. |
cammace
commented
Jun 8, 2017
| @@ -10,8 +10,9 @@ | |||
|
|
|||
| public class BaseTest { | |||
| public static final double DELTA = 1E-10; | |||
| private static final String BASE_PATH = "/res/"; | |||
| public static final double LARGE_DELTA = 0.1; | |||
There was a problem hiding this comment.
@zugaldia added a larger delta to offset the difference between API and calculated distances.
|
I've also added autoValues inside this PR to reinforce the immutable nature of RouteProgress. Ready for a review @zugaldia. |
zugaldia
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.