Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share common CacheHandle (backport for 2.17) #7692

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

DzmitryFomchyn
Copy link
Contributor

Description

Backports #7688 to 2.17

This PR makes CacheHandle be shared between Navigator and Router during MapboxNavigation initialization https://mapbox.atlassian.net/browse/NAVAND-1679

@DzmitryFomchyn DzmitryFomchyn requested a review from a team as a code owner January 8, 2024 11:36
Copy link

github-actions bot commented Jan 8, 2024

Changelog

Features

Bug fixes and improvements

  • Fixed a bug with multiple instances of cache which resulted in excessive memory consumption. [#7692](https://github.com/mapbox/mapbox-navigation-android/pull/7692)

Known issues ⚠️

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

  • The app is now considered as the one in active navigation only when an active route is set to MapboxNavigation. Previously it was always considered active. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)
  • When Android Auto host tells the app to stop active navigation because another app starts navigating, now SDK will enter FreeDrive mode instead of stopping trip session completely. [#7366](https://github.com/mapbox/mapbox-navigation-android/pull/7366)

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (21d7467) 74.08% compared to head (40f4149) 74.10%.
Report is 3 commits behind head on release-v2.17.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-v2.17    #7692      +/-   ##
===================================================
+ Coverage            74.08%   74.10%   +0.01%     
  Complexity            6152     6152              
===================================================
  Files                  833      834       +1     
  Lines                33130    33148      +18     
  Branches              3958     3953       -5     
===================================================
+ Hits                 24546    24564      +18     
  Misses                7050     7050              
  Partials              1534     1534              
Files Coverage Δ
...ava/com/mapbox/navigation/core/MapboxNavigation.kt 69.85% <100.00%> (+0.30%) ⬆️
...vigation/core/telemetry/events/FeedbackMetadata.kt 71.31% <ø> (ø)
...route/internal/util/DirectionsRouteRefreshUtils.kt 57.14% <100.00%> (ø)
...gation/navigator/internal/MapboxNativeNavigator.kt 0.00% <ø> (ø)
...va/com/mapbox/navigation/ui/shield/ShieldsCache.kt 92.50% <100.00%> (+0.60%) ⬆️
...box/navigation/core/NavigationComponentProvider.kt 56.00% <0.00%> (ø)
...on/navigator/internal/MapboxNativeNavigatorImpl.kt 0.00% <0.00%> (ø)
...n/base/route/DirectionsResponseParsingException.kt 0.00% <0.00%> (ø)
...om/mapbox/navigation/base/route/NavigationRoute.kt 72.01% <50.00%> (-0.56%) ⬇️
...ion/base/internal/utils/DirectionsResponseUtils.kt 0.00% <0.00%> (ø)
... and 1 more

@DzmitryFomchyn DzmitryFomchyn enabled auto-merge (squash) January 8, 2024 12:14
@DzmitryFomchyn DzmitryFomchyn merged commit c655bb7 into release-v2.17 Jan 8, 2024
33 of 38 checks passed
@DzmitryFomchyn DzmitryFomchyn deleted the df-cache-handle-2-17 branch January 8, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants