Move test doubles to TestHelper framework

MapboxCoreNavigationTests/MapboxNavigationServiceSpec.swift

@@ -2,6 +2,7 @@ import XCTest
 import Quick
 import Nimble
 import MapboxDirections
+import TestHelper
 @testable import MapboxCoreNavigation
 
 class MapboxNavigationServiceSpec: QuickSpec {

MapboxCoreNavigationTests/NavigationEventsManagerTests.swift

@@ -1,6 +1,8 @@
 import XCTest
+@testable import TestHelper
 @testable import MapboxCoreNavigation
 
+
 class NavigationEventsManagerTests: XCTestCase {
 
     func testMobileEventsManagerIsInitializedImmediately() {

MapboxCoreNavigationTests/NavigationServiceTests.swift

@@ -2,7 +2,7 @@ import XCTest
 import MapboxDirections
 import Turf
 import MapboxMobileEvents
-import TestHelper
+@testable import TestHelper
 @testable import MapboxCoreNavigation
 
 fileprivate let mbTestHeading: CLLocationDirection = 50

MapboxNavigation.xcodeproj/xcshareddata/xcbaselines/35CDA81821908F320072B675.xcbaseline/9C831563-2C49-4C7C-B2B5-A909580E1FC2.plist

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+	<key>classNames</key>
+	<dict>
+		<key>BenchTests</key>
+		<dict>
+			<key>testControlRoute1()</key>
+			<dict>
+				<key>com.apple.XCTPerformanceMetric_WallClockTime</key>
+				<dict>
+					<key>baselineAverage</key>
+					<real>0.736</real>
+					<key>baselineIntegrationDisplayName</key>
+					<string>Local Baseline</string>
+				</dict>
+			</dict>
+		</dict>
+	</dict>
+</dict>
+</plist>

MapboxNavigationTests/MapboxVoiceControllerTests.swift

@@ -97,24 +97,3 @@ class MockMapboxVoiceController: MapboxVoiceController {
     }
 }
 
-fileprivate extension Notification.Name {
-    enum MapboxVoiceTests {
-        static let prepareToPlay = NSNotification.Name("MapboxVoiceTests.prepareToPlay")
-        static let play = NSNotification.Name("MapboxVoiceTests.play")
-    }
-}
-class AudioPlayerDummy: AVAudioPlayer {
-    public let sound = NSDataAsset(name: "reroute-sound", bundle: .mapboxNavigation)!
-
-    lazy var notifier: NotificationCenter = .default
-    fileprivate typealias Note = Notification.Name.MapboxVoiceTests
-
-    override func prepareToPlay() -> Bool {
-        notifier.post(name: Note.prepareToPlay, object: self)
-        return true
-    }
-    override func play() -> Bool {
-        notifier.post(name: Note.play, object: self)
-        return true
-    }
-}

MapboxCoreNavigationTests/Support/DirectionsSpy.swift → TestHelper/DirectionsSpy.swift

@@ -2,21 +2,21 @@ import Foundation
 import MapboxDirections
 
 @objc(MBDirectionsSpy)
-class DirectionsSpy: Directions {
+public class DirectionsSpy: Directions {
 
-    var lastCalculateOptionsCompletion: RouteCompletionHandler?
+    public var lastCalculateOptionsCompletion: RouteCompletionHandler?
 
-    override func calculate(_ options: MatchOptions, completionHandler: @escaping Directions.MatchCompletionHandler) -> URLSessionDataTask {
+    override public func calculate(_ options: MatchOptions, completionHandler: @escaping Directions.MatchCompletionHandler) -> URLSessionDataTask {
         assert(false, "Not ready to handle \(#function)")
         return DummyURLSessionDataTask()
     }
 
-    override func calculate(_ options: RouteOptions, completionHandler: @escaping Directions.RouteCompletionHandler) -> URLSessionDataTask {
+    override public func calculate(_ options: RouteOptions, completionHandler: @escaping Directions.RouteCompletionHandler) -> URLSessionDataTask {
         lastCalculateOptionsCompletion = completionHandler
         return DummyURLSessionDataTask()
     }
 
-    override func calculateRoutes(matching options: MatchOptions, completionHandler: @escaping Directions.RouteCompletionHandler) -> URLSessionDataTask {
+    override public func calculateRoutes(matching options: MatchOptions, completionHandler: @escaping Directions.RouteCompletionHandler) -> URLSessionDataTask {
         assert(false, "Not ready to handle \(#function)")
         return DummyURLSessionDataTask()
     }
@@ -26,7 +26,7 @@ class DirectionsSpy: Directions {
             assert(false, "Can't fire a completion handler which doesn't exist!")
             return
         }
-
+        
         lastCalculateOptionsCompletion(waypoints, routes, error)
     }
 

TestHelper/DummyURLSessionDataTask.swift

@@ -0,0 +1,11 @@
+import Foundation
+
+public class DummyURLSessionDataTask: URLSessionDataTask {
+    override public func resume() {
+        //
+    }
+
+    override public func cancel() {
+        // 
+    }
+}

TestHelper/Fixture.swift

@@ -58,6 +58,21 @@ public class Fixture: NSObject {
         return URL(fileURLWithPath: path!)
     }
 
+    public class func locations(from name: String) -> [CLLocation] {
+        guard let path = Bundle(for: Fixture.self).path(forResource: name, ofType: "json") else {
+            assert(false, "Fixture \(name) not found.")
+            return []
+        }
+        guard let data = NSData(contentsOfFile: path) as Data? else {
+            assert(false, "No data found at \(path).")
+            return []
+        }
+
+        let locations = try! JSONDecoder().decode([Location].self, from: data)
+
+        return locations.map { CLLocation($0) }
+    }
+
     public class func route(from jsonFile: String) -> Route {
         let response = JSONFromFileNamed(name: jsonFile)
         let waypoints = Fixture.waypoints(from: jsonFile)

MapboxCoreNavigationTests/Support/NavigationEventsManagerTestDoubles.swift → TestHelper/NavigationEventsManagerTestDoubles.swift

@@ -3,7 +3,7 @@ import MapboxMobileEvents
 @testable import MapboxCoreNavigation
 import MapboxDirections
 
-class NavigationEventsManagerSpy: NavigationEventsManager {
+public class NavigationEventsManagerSpy: NavigationEventsManager {
 
     private var mobileEventsManagerSpy: MMEEventsManagerSpy!
 

TestHelper/NavigationServiceTestDoubles.swift

@@ -0,0 +1,60 @@
+import Foundation
+import MapboxCoreNavigation
+import MapboxDirections
+
+class RouteControllerDataSourceFake: RouterDataSource {
+
+    let manager = NavigationLocationManager()
+
+    var location: CLLocation? {
+        return manager.location
+    }
+
+    var locationProvider: NavigationLocationManager.Type {
+        return type(of: manager)
+    }
+}
+
+public class NavigationServiceDelegateSpy: NavigationServiceDelegate {
+    private(set) var recentMessages: [String] = []
+
+    public func reset() {
+        recentMessages.removeAll()
+    }
+
+    public func navigationService(_ service: NavigationService, shouldRerouteFrom location: CLLocation) -> Bool {
+        recentMessages.append(#function)
+        return true
+    }
+
+    public func navigationService(_ service: NavigationService, willRerouteFrom location: CLLocation) {
+        recentMessages.append(#function)
+    }
+
+    public func navigationService(_ service: NavigationService, shouldDiscard location: CLLocation) -> Bool {
+        recentMessages.append(#function)
+        return true
+    }
+
+    public func navigationService(_ service: NavigationService, didRerouteAlong route: Route, at location: CLLocation?, proactive: Bool) {
+        recentMessages.append(#function)
+    }
+
+    public func navigationService(_ service: NavigationService, didFailToRerouteWith error: Error) {
+        recentMessages.append(#function)
+    }
+
+    public func navigationService(_ service: NavigationService, didUpdate progress: RouteProgress, with location: CLLocation, rawLocation: CLLocation) {
+        recentMessages.append(#function)
+    }
+
+    public func navigationService(_ service: NavigationService, didArriveAt waypoint: Waypoint) -> Bool {
+        recentMessages.append(#function)
+        return true
+    }
+
+    public func navigationService(_ service: NavigationService, shouldPreventReroutesWhenArrivingAt waypoint: Waypoint) -> Bool {
+        recentMessages.append(#function)
+        return true
+    }
+}

TestHelper/SpeechAPISpy.swift

@@ -0,0 +1,57 @@
+import Foundation
+import MapboxSpeech
+import AVKit
+@testable import MapboxNavigation
+/**
+ * This class can be used as a substitute for SpeechSynthesizer under test, in order to verify whether expected calls were made.
+ */
+
+
+public class SpeechAPISpy: SpeechSynthesizer {
+    public struct AudioDataCall {
+        static let sound = NSDataAsset(name: "reroute-sound", bundle: .mapboxNavigation)!
+
+        let options: MapboxSpeech.SpeechOptions
+        let completion: SpeechSynthesizer.CompletionHandler
+
+        func fulfill() {
+            completion(AudioDataCall.sound.data, nil)
+        }
+    }
+
+    public var audioDataCalls: [AudioDataCall] = []
+
+    override public func audioData(with options: MapboxSpeech.SpeechOptions, completionHandler: @escaping MapboxSpeech.SpeechSynthesizer.CompletionHandler) -> URLSessionDataTask {
+        let call = AudioDataCall(options: options, completion: completionHandler)
+        audioDataCalls.append(call)
+        return DummyURLSessionDataTask()
+    }
+
+    public func reset() {
+        audioDataCalls.removeAll()
+    }
+}
+
+public class AudioPlayerDummy: AVAudioPlayer {
+    public let sound = NSDataAsset(name: "reroute-sound", bundle: .mapboxNavigation)!
+
+    lazy var notifier: NotificationCenter = .default
+    fileprivate typealias Note = Notification.Name.MapboxVoiceTests
+
+    override public func prepareToPlay() -> Bool {
+        notifier.post(name: Note.prepareToPlay, object: self)
+        return true
+    }
+
+    override public func play() -> Bool {
+        notifier.post(name: Note.play, object: self)
+        return true
+    }
+}
+
+extension Notification.Name {
+    enum MapboxVoiceTests {
+        static let prepareToPlay = NSNotification.Name("MapboxVoiceTests.prepareToPlay")
+        static let play = NSNotification.Name("MapboxVoiceTests.play")
+    }
+}