Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leg summary in step table can be ungrammatical in Spanish #600

Closed
1ec5 opened this issue Sep 11, 2017 · 1 comment
Closed

Leg summary in step table can be ungrammatical in Spanish #600

1ec5 opened this issue Sep 11, 2017 · 1 comment
Labels
bug Something isn’t working topic: localization

Comments

@1ec5
Copy link
Contributor

1ec5 commented Sep 11, 2017

LEG_MAJOR_WAYS_FORMAT and WAYPOINT_SOURCE_DESTINATION_FORMAT determine the format of the summary at the top of a leg in the step table when there are multiple legs. Each contains two names joined by the conjunction “and”. In Spanish, the equivalent conjunction is usually “y” but can change to “e” if the following word begins with an “i” or “y”. The navigation SDK nonetheless uses “y” unconditionally.

This problem affects Spanish localizations of all kinds of software (for example, citation-style-language/locales#87), but it’s especially acute for this particular string because so many street names and place names can begin with “I” or “Y”.

We’d need to add a special case in the code, because neither the .strings format nor Transifex supports varying conjunctions this way.

/cc @frederoni

@1ec5 1ec5 added bug Something isn’t working topic: localization labels Sep 11, 2017
@ericrwolfe
Copy link
Contributor

This is a super, super edge case all things considered and would be an extreme over-optimization on the client given other priorities at the moment.

  • Multiple waypoints (edge case)
  • Step table view (less commonly used view)
  • Multiple way names in summary (edge case)
  • Grammatical edge case in Spanish (edge case, relatively speaking)

If this needs to be fixed at all, it should be fixed on the in the directions API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working topic: localization
Projects
None yet
Development

No branches or pull requests

2 participants