Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Of Route Label Geocoding issues #921

Closed
2 tasks done
JThramer opened this issue Dec 7, 2017 · 2 comments
Closed
2 tasks done

End Of Route Label Geocoding issues #921

JThramer opened this issue Dec 7, 2017 · 2 comments
Assignees
Labels
bug Something isn’t working

Comments

@JThramer
Copy link
Contributor

JThramer commented Dec 7, 2017

@1ec5 has reported that the destination name label on the EORVC is misbehaving. He saw that the label would always either show OSRM names or coordinate pairs. This suggests a problem with the CLGeocoder implementation.

The expected order of precedence is:
Manually Set Name ➡️ OSRM Name ➡️ CLGeocoder Name ➡️ "You Have Arrived"

To Do:

  • Investigate CLGeocoder failure
  • Change coordinate Pair to "You Have Arrived" and hide static label in this case

/cc @bsudekum @frederoni @ericrwolfe

@JThramer JThramer added the bug Something isn’t working label Dec 7, 2017
@JThramer JThramer self-assigned this Dec 7, 2017
@JThramer JThramer changed the title End Of Route Label Precedence Incorrect End Of Route Label Geocoding issues Dec 7, 2017
@ericrwolfe
Copy link
Contributor

@JThramer Let's remove the fallback to the coordinate pair, and instead just show "You have arrived" in larger text instead of showing the smaller label.

@1ec5
Copy link
Contributor

1ec5 commented Dec 9, 2017

Fixed in #922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

No branches or pull requests

3 participants