Mapbox Directions API OSRM Name Fix #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the result `json` will produce `""` instead of the expected `nil`. Adding logic to compensate for this.
|
Would it be possible to add a test case? |
1ec5
reviewed
Dec 7, 2017
| let location = api["location"] as! [Double] | ||
| let coordinate = CLLocationCoordinate2D(geoJSON: location) | ||
| return Waypoint(coordinate: coordinate, name: local.name ?? api["name"] as? String) | ||
| let possibleAPIName = api["name"] as? String | ||
| let apiName = (possibleAPIName?.isEmpty ?? true) ? nil : possibleAPIName! |
There was a problem hiding this comment.
Core Navigation extends String with nonEmptyString, which is pretty convenient for situations like this. Feel free to copy it here, but make it internal, because MapboxDirections.swift shouldn’t be in the business of providing string processing helpers to clients.
JThramer
force-pushed
the
jerrad/osrm-name-nil
branch
from
fdfe846
to
8c0f938
Compare
|
I think #217 should be closed as well after this is merged and verified. |
This was referenced Dec 8, 2017
|
@JThramer mind checking out the test failure: |
1ec5
approved these changes
Dec 8, 2017
| import Foundation | ||
|
|
||
| extension String { | ||
| var isNotEmpty: Bool { return !isEmpty } |
There was a problem hiding this comment.
This is probably a bit extreme. For one thing, it’s more verbose than using the ! operator, which is more versatile than hard-coding negative versions of Boolean properties.
bsudekum
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly fixes issue mapbox/mapbox-navigation-ios#921, where an empty string is bypassing the
CLGeocoderand causing the coordinate logic to trigger (which does test for empty string -- a bug, but moot because it's being removed anyway). This change fixes this issue and makes sure thatwaypoint.name == nilwhen the Mapbox Directions API does not return an OSRM name for the waypoint.waypoints[n].namekeypath in the resultjsonwill produce""instead of the expectednil. Adding logic to compensate for this.ToDo:
MBRouteOptions.response(from:)and tests this edge-caseisNotEmpty/nonEmptyStringextension and usage/cc @bsudekum @1ec5 @frederoni