Draw slight left/right lanes #1270
Conversation
frederoni
force-pushed
the
fred/slight-lanes
branch
from
fad4cb6
to
488525e
Compare
There was a problem hiding this comment.
Should we also verify the road class?
It鈥檚 possible for the end of a motorway to have ordinary turn lanes. There are some prominent signalized freeway ends in Washington, D.C., and San Francisco, for example. I think it would be more reliable to treat right as slightRight if the maneuver type is takeOffRamp or reachFork.
bsudekum
force-pushed
the
fred/slight-lanes
branch
from
488525e
to
3e3f710
Compare
| @@ -1,6 +1,6 @@ | |||
| import XCTest | |||
| import FBSnapshotTestCase | |||
| import MapboxDirections | |||
| @testable import MapboxDirections | |||
There was a problem hiding this comment.
Getting the error: Module 'MapboxDirections' was not compiled for testing
Does something need to change in the cartfile to make this happen?
There was a problem hiding this comment.
Is this @testable needed? This PR doesn鈥檛 seem to introduce any calls to private methods.
Never mind, it鈥檚 Lane(indications:). Maybe we should make that initializer public. It鈥檚 a good practice to always make at least one initializer public for any class, to facilitate unit testing.
There was a problem hiding this comment.
Yes, this init is private: https://github.com/mapbox/mapbox-navigation-ios/pull/1270/files#diff-ec73732e527cb329ec167966c37b7cbeR50
There was a problem hiding this comment.
Not sure what the best practice is here but testable imports publicizes private methods in frameworks built with its configuration set to debug (carthage update/bootstrap --configuration Debug) so we can keep the initializer private.
Fixes #1267 show slight arrows on freeway lanes
Should we also verify the road class? 馃
@1ec5 @bsudekum 馃憖