Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sequence.swift to MapboxNavigation podspec #1296

Merged
merged 2 commits into from Apr 13, 2018
Merged

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Apr 13, 2018

Include Sequence.swift in MapboxNavigation, fixing a compilation error when building a version of MapboxNavigation that is assembled by CocoaPods instead of being built from the checked-in Xcode project.

Fixes #1295.

/cc @frederoni @JThramer @bsudekum

@1ec5 1ec5 added build Issues related to builds and dependency management. CocoaPods labels Apr 13, 2018
@1ec5 1ec5 self-assigned this Apr 13, 2018
@1ec5 1ec5 requested review from frederoni and JThramer April 13, 2018 05:13
@frederoni
Copy link
Contributor

frederoni commented Apr 13, 2018

The reason why CI completed successfully despite running the CocoaPods integration test was that piping xcodebuild through xcpretty caused the command to return exit code 0 instead of 65. Using set -o pipefail delegates the correct result through the pipe.

@@ -32,7 +32,7 @@ Pod::Spec.new do |s|

# ――― Source Code ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― #

s.source_files = ["MapboxNavigation/*", "MapboxCoreNavigation/{Date,Geometry,String}.swift"]
s.source_files = ["MapboxNavigation/*", "MapboxCoreNavigation/{Date,Geometry,Sequence,String}.swift"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to drop "Geometry"

@1ec5 1ec5 merged commit 7e8f536 into master Apr 13, 2018
@1ec5 1ec5 deleted the 1ec5-sequence-podspec-1295 branch April 13, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapboxNavigation depends on private compactMap(_:) method
2 participants