Update style color palette for v3

[frederoni]

Partially closes #1347

This PR updates the color palette for v3 guidance day/night styles.
v2 guidance map styles will still be used by default but convenient methods for any version has been added in the form of (MGLStyle.navigationGuidance{Day/Night}StyleURL(version:).

@1ec5 @bsudekum 👀

[bsudekum]

What are we gaining by passing through line color/width?

[bsudekum]

Oh I see.

[frederoni]

Yea, the alternate route didn't have a casing before so this method is now used for creating the alternate route style layer and the casing layer.

[bsudekum]

I'm slightly concerned with the contrast here. Now since the strongest color here is white, we do not get such an easy division between ui elements and the map style.

/cc @aparlato @cjballard @1ec5 @brsbl

[1ec5]

The second screenshot demonstrates that we should dim the rest of the screen when the end-of-route feedback view controller comes into view. But I think that would need to be a separate PR focused on the end-of-route experience.

/cc @JThramer

[bsudekum]

I'm going to remove this issue from the v0.17.0 milestone as there seems to be some kinks to work out with the style/ui still.

[Cjballard-zz]

Exploring a few options for increasing contrast here. We could style the top banner to be Mapbox gray-blue (#273D56) to provide some weight and color at the top of the view.

We could style the sub-banners as either slightly darker or slightly lighter to make it feel connected – I prefer the slightly darker color, but want to crowdsource some thoughts. From there, tweaked a little bit of spacing and included a 1pt light-gray (#C6D2E1) top border on the bottom tray to provide some contrast with the map style. Just some quick exploring - thoughts? /cc @bsudekum @frederoni @1ec5

[bsudekum]

@cjballard noting, we have two styles: day and night. Darker tones are usually reserved for the night style/UI.

[Cjballard-zz]

@bsudekum Definitely. Don't mean to infringe on night mode, but explore how we can put some contrast & color in the current day theme UI. Mapbox core blue felt a little too Google-blue in this context, but I can experiment with some other options.

[Cjballard-zz]

An easier solution without changing banner color could be adding a 1pt light-gray (#e2e2e2 or whichever our preferred light gray we already use) line to the top of each trip tray & arrival card element to create some distinction. It's still light, but starts to create separation b/w elements. @bsudekum

[brsbl-zz]

How about we use #F2F5FA or #BCCBDE per our tertiary brand palette?

[frederoni]

Made a few updates here using colors from the brand palette.
@cjballard should these lines be 1px instead of 1pt?

[Cjballard-zz]

@frederoni Yeah, especially with the light gray/blue that's looking a little thick.

[frederoni]

1px line

[Cjballard-zz]

@frederoni Much better, looks good to me.

[frederoni]

@bsudekum @vincethecoder this PR is ready for review

[bsudekum]

I'd like to put a hold on this PR for a moment. I'm not sure if the new styles and UI add value to our customers. The lack of contrast in the style is still an issue for me.

[bsudekum]

@frederoni looks good, want to add a changelog entry with the new style-able classes for developers who are using a custom Style?

[vincethecoder]

LGTM 👍

[frederoni]

want to add a changelog entry with the new style-able classes

the SeparatorView is actually old so there are no new stylable classes but I added a blurb about the new convenient methods on MGLStyle.

[1ec5]

Note that, despite the title of this PR, navigationGuidanceDayStyleURL and navigationGuidanceNightStyleURL still point to the v2 styles. #1347 continues to track upgrading to the v3 styles.