Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Service, Part 1 #1602

Merged
merged 41 commits into from
Sep 26, 2018
Merged

Navigation Service, Part 1 #1602

merged 41 commits into from
Sep 26, 2018

Commits on Aug 9, 2018

  1. WIP: Building out scaffolding for MapboxNavigationService

    Jerrad Thramer committed Aug 9, 2018
    Configuration menu
    Copy the full SHA
    57ed105 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2018

  1. WIP: It compiles! (Completed building out scaffolding around Navigati… 

    …onService)
    Jerrad Thramer committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    ef09aac View commit details
    Browse the repository at this point in the history

  2. WIP: It's Aliiiiive! (Hooking NavigationService up to consumer, movin… 

    …g location source out)
    Jerrad Thramer committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    23818fc View commit details
    Browse the repository at this point in the history

  3. WIP: PR Comments

    Jerrad Thramer committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    a9611d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Update all the tests!

    Jerrad Thramer committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    8f47670 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. Cleaning up after myself

    Jerrad Thramer committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    099ddc4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jerrad/146-navigation-service

    Jerrad Thramer committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    b24c8bf View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Decoupling EventsManager from RouteController

    Jerrad Thramer committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    518a89e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jerrad/146-navigation-service

    Jerrad Thramer committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    8e44849 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. WIP: Temporarily disabling TunnelIntersectionTests for refactor

    Jerrad Thramer committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    d169b06 View commit details
    Browse the repository at this point in the history

  2. Decoupling the TunnelIntersectionManager (now TunnelAuthority) from t… 

    …he RouteController.
    Jerrad Thramer committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    3a80e14 View commit details
    Browse the repository at this point in the history

  3. Gah, forgot about the OBJ-C interface!

    Jerrad Thramer committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    cedabcb View commit details
    Browse the repository at this point in the history

  4. Prevent yo-yoing by only passing synthetic location updates onto the … 

    …router during simulation.
    Jerrad Thramer committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    230351f View commit details
    Browse the repository at this point in the history

  5. Fix naming conventions and coding style

    @frederoni
    frederoni committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    8c04240 View commit details
    Browse the repository at this point in the history

  6. Simplified TunnelAuthority and refactor accompanying tests 

    Co-authored-by: Jerrad Thramer <jerrad.thramer@mapbox.com>
    @frederoni
    frederoni and Jerrad Thramer committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    7f5aa7f View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Completely decoupling tunnel detection from route simulation. This si… 

    …mplifies the logic a great deal. Tunnel detection is now a concern in `NavigationViewController`.
    Jerrad Thramer committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    089a39a View commit details
    Browse the repository at this point in the history

  2. Fixing issue where countdown timer payload was being executed on back… 

    …ground queue, which was causing problems downstream when we started simulation (effectively creating a CLLocationManager on a background queue, which is verboten)
    Jerrad Thramer committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    9c5b70d View commit details
    Browse the repository at this point in the history

  3. Fixing issue where we were using timer.cancel() (which is permanent) … 

    …instead of timer.suspend() (which is temporary). Also guarding against statefulness problems in timer outlined by (somewhat scant) GCD documentation.
    Jerrad Thramer committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    950cd68 View commit details
    Browse the repository at this point in the history

  4. Fixing Tests. Gah. 

    * Derp. Don't throw every organic location update away, only the first qualified one if we're simulating.
* Hooking new simulationOptions enum up to OBJ-C Sample App.
    Jerrad Thramer committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    d49ebdc View commit details
    Browse the repository at this point in the history

  5. PR Comments, and preliminary polish.

    Jerrad Thramer committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    3e8edde View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Merge branch 'master' into jerrad/146-navigation-service 

    # Conflicts:
#	MapboxNavigation/RouteMapViewController.swift
    Jerrad Thramer committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    d6f8498 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. Adding new NavigationServiceDelegate type and plumbing everything t… 

    …o use that delegate protocol. Also changed `RouteControllerDelegate` into `RouterDelegate`.
    Jerrad Thramer committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    8a8fc79 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into jerrad/146-navigation-service 

    # Conflicts:
#	MapboxCoreNavigation/RouteController.swift
    Jerrad Thramer committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    7b8ed23 View commit details
    Browse the repository at this point in the history

  3. Hooking up example

    Jerrad Thramer committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    e454202 View commit details
    Browse the repository at this point in the history

  4. cleanup, random comment fix

    Jerrad Thramer committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    45795e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2018

  1. Merge branch 'master' into jerrad/146-navigation-service

    Jerrad Thramer committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    a139f89 View commit details
    Browse the repository at this point in the history

  2. Fixing tests.

    Jerrad Thramer committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    4fc2e2a View commit details
    Browse the repository at this point in the history

  3. Consolidating directions reference into a single-point-of-truth. 

    Instead of directions being memoized within the NavigationViewController, it is now a computed property, based off of the navigationService.
Also cleaning up some unused cruft.
    Jerrad Thramer committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    297f7b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. Merge branch 'master' into jerrad/146-navigation-service 

    # Conflicts:
#	Examples/Objective-C/ViewController.m
#	MapboxNavigation/NavigationViewController.swift
#	MapboxNavigationTests/LeaksSpec.swift
#	MapboxNavigationTests/NavigationViewControllerTests.swift
    Jerrad Thramer committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ee3cd30 View commit details
    Browse the repository at this point in the history

  2. Fixing merge clobber

    Jerrad Thramer committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    cec16b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Merge branch 'epic/nav-native' into jerrad/146-navigation-service 

    # Conflicts:
#	Cartfile.resolved
#	Examples/Objective-C/ViewController.m
#	Examples/Swift/CustomViewController.swift
#	MapboxCoreNavigation/EventDetails.swift
#	MapboxCoreNavigation/EventsManager.swift
#	MapboxCoreNavigation/RouteController.swift
#	MapboxCoreNavigationTests/MapboxCoreNavigationTests.swift
#	MapboxCoreNavigationTests/RouteControllerTests.swift
#	MapboxCoreNavigationTests/TunnelIntersectionManagerTests.swift
#	MapboxNavigation.xcodeproj/project.pbxproj
#	MapboxNavigation/FeedbackViewController.swift
#	MapboxNavigation/NavigationViewController.swift
#	MapboxNavigation/RouteMapViewController.swift
#	MapboxNavigationTests/LaneTests.swift
#	MapboxNavigationTests/LeaksSpec.swift
#	MapboxNavigationTests/NavigationViewControllerTests.swift
#	MapboxNavigationTests/StepsViewControllerTests.swift
    Jerrad Thramer authored and Jerrad Thramer committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    b5c0c03 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. WIP: Trying to fix test failures

    Jerrad Thramer authored and Jerrad Thramer committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    fdcb350 View commit details
    Browse the repository at this point in the history

  2. WIP: Fixed crash, now working on the actual failures, which is "we di… 

    …dn't get a progress update" related
    Jerrad Thramer authored and Jerrad Thramer committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    9c7c9f9 View commit details
    Browse the repository at this point in the history

  3. Fixed issue where wrong type of location manager was used for core na… 

    …vigation tests.
    Jerrad Thramer authored and Jerrad Thramer committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    2049a30 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2018

  1. Fixing remaining tests

    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    41265b1 View commit details
    Browse the repository at this point in the history

  2. Final polish -- fixing issue where speed multiplier changes weren't b… 

    …eing passed through on carplay
    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    89c73cf View commit details
    Browse the repository at this point in the history

  3. Fixing test cruft where testing type is no longer extant on stubbed e… 

    …vents manager
    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    2e161df View commit details
    Browse the repository at this point in the history

  4. Reverting removal of ostensibly redundant XCTest availability macros

    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    6bccfd6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'epic/nav-native' into jerrad/146-navigation-service 

    # Conflicts:
#	MapboxCoreNavigation/SimulatedLocationManager.swift
    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    edbb56d View commit details
    Browse the repository at this point in the history

  6. Forgot this one

    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    0994b2b View commit details
    Browse the repository at this point in the history

  7. Fixing some post-merge testing issues

    Jerrad Thramer authored and Jerrad Thramer committed Sep 26, 2018
    Configuration menu
    Copy the full SHA
    e9a7781 View commit details
    Browse the repository at this point in the history