Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also move user puck during course tracking if necessary #1653

Merged
merged 1 commit into from Sep 5, 2018
Merged

Also move user puck during course tracking if necessary #1653

merged 1 commit into from Sep 5, 2018

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Sep 5, 2018

During course tracking, ensure that the user puck moves along with the camera the first time NavigationMapView.updateCourseTracking(location:animated:) gets called after adjusting the map view’s layout.

Fixes #1651.

/cc @JThramer @bsudekum

@1ec5 1ec5 added bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay labels Sep 5, 2018
@1ec5 1ec5 added this to the v0.20.0 milestone Sep 5, 2018
@1ec5 1ec5 self-assigned this Sep 5, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Sep 5, 2018

Before, in CarPlay (on the carplay branch), the puck would either stay put as the route line shifts to the right to accommodate the maneuver overlay, or it would disappear entirely:

detached
rotated
invisible

This PR synchronizes the puck with the camera and thus the route line:

attached

@1ec5 1ec5 mentioned this pull request Sep 5, 2018
Closed
JThramer
JThramer approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@1ec5 1ec5 merged commit c7f60a1 into master Sep 5, 2018
@1ec5 1ec5 deleted the 1ec5-sideline-puck-1651 branch September 5, 2018 20:22
@1ec5 1ec5 modified the milestones: v0.20.0, v0.21.0 Sep 17, 2018
@1ec5 1ec5 mentioned this pull request Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

@bsudekum bsudekum Awaiting requested review from bsudekum

Assignees

@1ec5 1ec5

Labels
bug Something isn’t working CarPlay Bugs, improvements and feature requests on Apple CarPlay
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1ec5 @JThramer