Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence reroute questioning if reroute is already inflight #1930

Merged
merged 1 commit into from Jan 15, 2019

Conversation

JThramer
Copy link
Contributor

Quick fix. Implements #1929.

/cc @mapbox/navigation-ios

Copy link
Contributor

@akitchen akitchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are commas considered more idiomatic than && ? The mix of commas and ?? is weird to read at first, but LGTM

@JThramer
Copy link
Contributor Author

@akitchen I generally try and use commas if there are exclusively AND statements in the clause ("This, that, and the other"), and use explicit boolean notation if the clause is more complex. ("This and that, but not those or this other thing.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants