New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added safe-area handling to BottomBannerViewController. #1982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional view to add some padding seems excessive. Can we constrain the bottom element in the bottom banner with safeBottomAnchor
?
Also, the NightStyle inherits from the DayStyle, so we need an appropriate color there as well. Can the padding view’s background color be transparent? Much like the UIStackView, a padding view should be a non-rendering view. However, preferably, we shouldn't have a padding view at all.
Posterity: after talking with @frederoni, we decided to make the bottom padding area a |
We chatted about this, compromised on one type for both views (banner and padding)
That's what I get for trying to edit the changeling with GitHub.
Fixes #1978. Adds a "padding" view that accounts for the device's bottom safe area, if any.
Test reference:
To-do:
/cc @mapbox/navigation-ios