Fix progress updates order of execution #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
fix-progress-order
branch
from
6a8804b
to
1487aed
Compare
frederoni
commented
Mar 14, 2019
| XCTAssertEqual(points[2].type, .spoken) | ||
|
|
||
| XCTAssertEqual(points[3].legIndex, 0) | ||
| XCTAssertEqual(points[3].stepIndex, 1) |
There was a problem hiding this comment.
This assertion failed (prior to 05cc3e7) because stepIndex is 0, indicating that we are going backward in time or the indexes were not in sync, the latter being the case here. spokenInstructionIndex went from 1 to 0 when stepIndex remained on 0.
JThramer
approved these changes
Mar 14, 2019
1ec5
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateSpokenInstructionProgress(status:willReRoute:)must happen after step progress and leg progress has been updated to keep the indexes in sync.ref #2004 (comment)
cc @1ec5 @JThramer