Always hide compass on CarPlay during navigation #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
akitchen
reviewed
Mar 22, 2019
akitchen
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always hide the compass on CarPlay during the navigation activity (in other words, in CarPlayNavigationViewController’s map view). Otherwise, the compass would appear in an odd position to the left of the column of map buttons. Also, the compass has an analog design more appropriate for the browsing activity but not for the navigation activity.
The analog compass remains in the browsing activity. A digital compass will be added as part of #1217 for parity with other CarPlay navigation applications.
/cc @mapbox/navigation-ios