Clean up CarPlay route preview pane #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the “street” from the CarPlay route preview pane; it was set redundantly to the destination waypoint’s name.
1ec5
force-pushed
the
1ec5-carplay-preview-stats-2090
branch
from
ab9743a
to
98701f0
Compare
frederoni
approved these changes
May 2, 2019
That hasn’t been implemented yet; tracking in #2122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the “street address” from the CarPlay route preview pane; it was set redundantly to the destination waypoint’s name. For consistency, call
CarPlayManagerDelegate.carPlayManager(_:willPreview:)also when programmatically starting a new route in CarPlay. Show statistics like the distance and estimated travel time when previewing a selected route.Fixes #2090.
/cc @mapbox/navigation-ios