Remove viewport workaround in CarPlay

[frederoni]

Now that mapbox/mapbox-gl-native#14664 gained traction, I took the chance to remove the hacky workaround for the viewport in CarPlay and the NavigationMapView.

This PR is blocked by the PR mentioned above, and a new release of the Maps SDK. As well as some cleanup work and testing.

This PR will unblock #1139

Fixes #2134.

cc @mapbox/navigation-ios @astojilj

[astojilj]

@frederoni Thanks. Looks good - simpler, though I'm not familiar with the code to properly review it.
It would be interesting to see how it affects performance - the viewport area should be now 2 times smaller:
from the screenshot looks like it was (1.5 * width + 100pixels) x (1.5 * height + 100pixels), width and height and 100px are in logical coordinates.

100 pixels comes from CollisionIndex viewportPadding that we could also try to tweak.

[1ec5]

Awesome – so glad this is becoming a reality!

I’m not sure why, but the vanishing point is offset slightly too far to the right, or the puck is offset slightly too far to the left. The puck’s arrow and the straightaway along the route should look like they point directly upward, tangent to the top edge of the screen.

[frederoni]

I’m not sure why, but the vanishing point is offset slightly too far to the right, or the puck is offset slightly too far to the left.

Yea, the userAnchorPoint doesn't exactly match the safeArea’s centerY which results in the viewpoint’s X position being out of sync every minor turn, so there is a small discrepancy that'll need to be addressed before this PR can land. Good pixelhunting 👁

[1ec5]

mapbox/mapbox-gl-native#14664 is shipping today as part of map SDK v5.1.0. Since the bug fix isn’t shipping as a semver-major change, the workaround needs to be removed to avoid overcorrecting the vanishing point.

[1ec5]

#2143 prevents this SDK from working with v5.1.0 for the time being, but we need to remove that restriction and depend on v5.1.x in short order to avoid blocking various applications from upgrading the map SDK.

[1ec5]

This comment was a bit misleading: the actual workarounds were the paddings added in showcase(_:padding:animated:) and fit(to:facing:padding:animated:), not the one here. The edge padding here is necessary in order to account for the puck’s uncentered location even within the content frame.

/ref #2145 (comment)

[1ec5]

These assertions are failing and crashing on iOS 12 for some odd reason:

mapbox-navigation-ios/MapboxCoreNavigationTests/NavigationEventsManagerTests.swift

Lines 55 to 57 in db19ffe

	XCTAssertEqual(Int(round(durationBetweenDepartAndArrive)), 1041)
	XCTAssertEqual(Int(round(durationBetweenDepartAndReroute)), 225)
	XCTAssertEqual(Int(round(durationBetweenRerouteAndArrive)), 816)