Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reroutesProactively mutable on Router #2157

Merged
merged 1 commit into from Jun 25, 2019
Merged

Make reroutesProactively mutable on Router #2157

merged 1 commit into from Jun 25, 2019

Conversation

frederoni
Copy link
Contributor

Fixes #2153

The Router protocol declares reroutesProactively non-mutable, but both RouteController and LegacyRouteController defines the variable mutable. Making this mutable on the protocol prevents excessive casting.

cc @1ec5

1ec5
1ec5 reviewed Jun 24, 2019
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changelog entry:

  • Added a setter to the Router.reroutesProactively property. (#2157)

@frederoni frederoni force-pushed the fred/mutable-proactive-rerouting branch from d7b4a1d to f2358b0 Compare June 25, 2019 13:44
@frederoni frederoni force-pushed the fred/mutable-proactive-rerouting branch from f2358b0 to 6529107 Compare June 25, 2019 13:46
@frederoni frederoni merged commit 1b2962f into master Jun 25, 2019
@frederoni frederoni deleted the fred/mutable-proactive-rerouting branch June 25, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't opt-out out of faster-route detection
2 participants
@frederoni @1ec5