Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sizing of FeedbackViewCategoryCell #2630

Merged
merged 1 commit into from Sep 15, 2020
Merged

Conversation

avi-c
Copy link
Contributor

@avi-c avi-c commented Sep 15, 2020

Use some vertical padding instead of trying to calculate the height of the category title since it may vary due to font size fitting.

@avi-c avi-c requested a review from 1ec5 September 15, 2020 01:58
@avi-c
Copy link
Contributor Author

avi-c commented Sep 15, 2020

Before and after photos:

IMG_DC45E1E620F4-1

IMG_9278

@1ec5 1ec5 added this to the v1.0.0 milestone Sep 15, 2020
@1ec5 1ec5 added bug Something isn’t working topic: design topic: telemetry labels Sep 15, 2020
@avi-c avi-c merged commit 1ea910d into master Sep 15, 2020
@avi-c avi-c deleted the ac-FixFeedbackCategoryCellSize branch September 15, 2020 02:12
1ec5 pushed a commit that referenced this pull request Sep 17, 2020
Fix sizing of FeedbackViewCategoryCell

Cherry-picked from 1ea910d.
@1ec5
Copy link
Contributor

1ec5 commented Sep 17, 2020

Cherry-picked into the release-v1.0 branch as 1ea910d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants