Update to Mapbox Maps 10.0.0-beta.20, Navigation Native 50.0.0 and Common 12.0.0.
#3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
added
build
MaximAlien
force-pushed
the
maxim/update-mapbox-maps-dependency
branch
from
2fc4328
to
d0bb78f
Compare
1ec5
approved these changes
May 19, 2021
| var layerPosition: MapboxMaps.LayerPosition? = nil | ||
|
|
||
| if isMainRoute { | ||
| if let aboveLayerIdentifier = mapView.mainRouteLineParentLayerIdentifier { |
There was a problem hiding this comment.
If the identifier is nil, this method silently returns without adding a layer or printing to the console. Is that intentional? It’d be easier to keep track of cases like this by making layerPosition constant (but still optional).
There was a problem hiding this comment.
I've updated the code to use let instead of var. Otherwise code should work fine: if there is no layerPosition layer will be added at the top of the stack.
MaximAlien
force-pushed
the
maxim/update-mapbox-maps-dependency
branch
from
b1315b2
to
b259fbe
Compare
MaximAlien
changed the title
main.10.0.0-beta.20, Navigation Native 50.0.0 and Common 12.0.0.
S2Ler
reviewed
May 20, 2021
| @@ -72,22 +72,13 @@ class Navigator { | |||
| Restrict direct initializer access. | |||
| */ | |||
| private init() { | |||
MaximAlien
force-pushed
the
maxim/update-mapbox-maps-dependency
branch
from
8c0ebc7
to
f20b0be
Compare
MaximAlien
force-pushed
the
maxim/update-mapbox-maps-dependency
branch
from
856fae6
to
3fe773a
Compare
…on of Mapbox Maps from `main`.
… Maps from `main`.
…ner` and brining back ``.
MaximAlien
force-pushed
the
maxim/update-mapbox-maps-dependency
branch
from
3fe773a
to
684a23e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates Mapbox Maps to
10.0.0-beta.20(pointing tomainfor now), Navigation Native50.0.0and Common12.0.0.