Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mapbox Maps v10.0.0-rc.1, Mapbox Directions v2.0.0-beta.5, Turf v2.0.0-beta.1. #3077

Merged
merged 4 commits into from Jun 23, 2021

Conversation

MaximAlien
Copy link
Contributor

@MaximAlien MaximAlien commented Jun 14, 2021

Description

Update to Mapbox Maps v10.0.0-rc.1, Mapbox Directions v2.0.0-beta.5, Turf v2.0.0-beta.1 and Mapbox Common v14.0.0.

testSKUTokensMatch was temporarily disabled due to changes on Maps SDK side, which lead to SKU ID structure changes. Test should be revised once new pricing implementation lands on Navigation SDK side.

@MaximAlien MaximAlien added this to the v2.0.0 (RC) milestone Jun 14, 2021
@MaximAlien MaximAlien requested a review from a team June 14, 2021 08:02
@MaximAlien MaximAlien self-assigned this Jun 14, 2021
@MaximAlien MaximAlien marked this pull request as draft June 14, 2021 08:11
@MaximAlien MaximAlien requested a review from a team June 14, 2021 08:11
@S2Ler
Copy link
Contributor

S2Ler commented Jun 16, 2021

@MaximAlien Please include https://github.com/mapbox/mapbox-directions-swift/releases/tag/v2.0.0-beta.5 in this release.

@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 3 times, most recently from 937352e to 8abab4b Compare June 16, 2021 11:12
@1ec5
Copy link
Contributor

1ec5 commented Jun 16, 2021

This is waiting on a MapboxNavigationNative release that depends on MapboxCommon v14.0.0. It’s also pending a fix for an apparent incompatibility between MapboxMaps v10.0.0-rc.1 and MapboxCommon v14.1.0, which would get pulled in automatically because both MapboxMaps and MapboxNavigationNative allow minor versions of MapboxCommon as of mapbox/mapbox-navigation-native-ios#6. That fix is being tracked in mapbox/mapbox-maps-ios#477.

@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 2 times, most recently from d3310e7 to 203aa82 Compare June 17, 2021 10:39
@MaximAlien MaximAlien requested a review from a team June 17, 2021 11:00
@1ec5 1ec5 added the build Issues related to builds and dependency management. label Jun 17, 2021
@MaximAlien MaximAlien marked this pull request as ready for review June 21, 2021 09:33
@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 3 times, most recently from 8c4d9ee to 27d1713 Compare June 21, 2021 14:39
@S2Ler S2Ler changed the title Update to Mapbox Maps v10.0.0-rc.1, Mapbox Directions v2.0.0-beta.4, Turf v2.0.0-beta.1. Update to Mapbox Maps v10.0.0-rc.1, Mapbox Directions v2.0.0-beta.5, Turf v2.0.0-beta.1. Jun 21, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
…SDK side, which lead to SKU ID structure changes. Test should be revised once new pricing implementation lands on Navigation SDK side.
@MaximAlien MaximAlien requested a review from a team June 23, 2021 08:26
@MaximAlien MaximAlien merged commit 9325fa1 into release-v2.0 Jun 23, 2021
@MaximAlien MaximAlien deleted the maxim/update-dependencies branch June 23, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants