v2.0.0-beta.17 #3156
v2.0.0-beta.17 #3156
Conversation
1ec5
added
build
| if let path = path { | ||
| completionHandler(URL(fileURLWithPath: path)) | ||
| } else { | ||
| completionHandler(nil) | ||
| } | ||
| self?.historyRecorder?.startRecording() |
There was a problem hiding this comment.
According to the HistoryRecorderHandle.stopRecording(result:) documentation, we have to explicitly restart history recording after it’s done writing out history, a change from before when dumpHistory(result:) would keep history recording going.
There was a problem hiding this comment.
Unfortunately, this change seems to be causing various test failures:
MapboxCoreNavigationTests.PassiveLocationManagerTests
testHistoryRecording, XCTAssertNotNil failed
/Users/distiller/project/Tests/MapboxCoreNavigationTests/PassiveLocationManagerTests.swift:124
PassiveLocationManager.writeHistory { url in
XCTAssertNotNil(url)
historyExpectation.fulfill()
| @@ -142,6 +143,7 @@ class Navigator { | |||
| navigator.setElectronicHorizonObserverFor(self) | |||
| navigator.addObserver(for: self) | |||
| navigator.setFallbackVersionsObserverFor(self) | |||
| historyRecorder?.startRecording() | |||
There was a problem hiding this comment.
The relevant change in MapboxNavigationNative clearly expects the history recorder to be started explicitly at some point before dumping (or “stopping”) history, so I’ve added a bit here to start recording basically as soon as possible. In principle, we could start recording more lazily, perhaps based on some application-defined behavior, but we don’t have a convenient place to do that, so for now I’m just preserving the previous behavior.
/cc @mskurydin @DmitryAk
Updated the Xcode project, CocoaPods podspec, and readmes for v2.0.0-beta.17.
In addition to the usual updates, this PR upgrades to MapboxNavigationNative v56.0.0, which includes the following changes versus previous v2.0.0 betas:
Additionally, I took the opportunity to refactor
OpenLRStandard, with a view toward future enhancements to the road objects/incidents API:OpenLRStandardenumeration with anOpenLRIdentifierenumeration that includes aRoadObjectIdentifieras an associated value.RoadObjectMatcher.matchOpenLR(location:standard:identifier:)has been renamed toRoadObjectMatcher.matchOpenLR(location:identifier:). (v2.0.0-beta.17 #3156)And a typo in the jazzy table of contents was corrected.
/cc @mapbox/navigation-ios