New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Mapbox Maps v10.0.0-rc.5
and Navigation Native v60.0.0
.
#3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
from
July 14, 2021 20:43
a904d32
to
7a09e4e
Compare
MaximAlien
changed the title
Update to the latest version of Mapbox Maps.
Update to Mapbox Maps Jul 14, 2021
v10.0.0-rc.4
.
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
3 times, most recently
from
July 19, 2021 17:34
9ca42dd
to
e44064b
Compare
S2Ler
approved these changes
Jul 20, 2021
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
4 times, most recently
from
July 22, 2021 16:03
c902d2a
to
6ae0ae6
Compare
MaximAlien
changed the title
Update to Mapbox Maps
Update to Mapbox Maps Jul 22, 2021
v10.0.0-rc.4
.v10.0.0-rc.4
and Navigation Native v59.0.0
.
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
5 times, most recently
from
July 28, 2021 19:29
b218c74
to
fefe858
Compare
MaximAlien
changed the title
Update to Mapbox Maps
Update to Mapbox Maps Jul 28, 2021
v10.0.0-rc.4
and Navigation Native v59.0.0
.v10.0.0-rc.5
and Navigation Native v60.0.0
.
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
2 times, most recently
from
August 2, 2021 16:01
96c8c3d
to
cb5b84f
Compare
jill-cardamon
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
MaximAlien
force-pushed
the
maxim/update-dependencies
branch
from
August 2, 2021 18:43
1b5fce4
to
4bc1f75
Compare
…`distanceToNearestExit` in `DistancedRoadObject` use optional values.
MaximAlien
commented
Aug 2, 2021
@@ -108,15 +108,15 @@ public enum DistancedRoadObject { | |||
let info = native.distanceInfo.getPolygonDistanceInfo() | |||
self = .polygon(identifier: native.roadObjectId, | |||
type: RoadObjectType(native.type), | |||
distanceToNearestEntry: info.distanceToNearestEntry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant about this change, but to be more defensive I'd rather return an optional value instead of crashing or asserting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to Mapbox Maps
v10.0.0-rc.5
and Navigation Nativev60.0.0
.