Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mapbox Maps v10.0.0-rc.5 and Navigation Native v60.0.0. #3162

Merged
merged 6 commits into from Aug 2, 2021

Conversation

MaximAlien
Copy link
Contributor

@MaximAlien MaximAlien commented Jul 12, 2021

Description

Update to Mapbox Maps v10.0.0-rc.5 and Navigation Native v60.0.0.

@MaximAlien MaximAlien added the build Issues related to builds and dependency management. label Jul 12, 2021
@MaximAlien MaximAlien added this to the v2.0.0 (RC) milestone Jul 12, 2021
@MaximAlien MaximAlien self-assigned this Jul 12, 2021
@MaximAlien MaximAlien marked this pull request as draft July 12, 2021 18:22
@MaximAlien MaximAlien requested a review from a team July 14, 2021 15:43
@MaximAlien MaximAlien changed the title Update to the latest version of Mapbox Maps. Update to Mapbox Maps v10.0.0-rc.4. Jul 14, 2021
@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 3 times, most recently from 9ca42dd to e44064b Compare July 19, 2021 17:34
@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 4 times, most recently from c902d2a to 6ae0ae6 Compare July 22, 2021 16:03
@MaximAlien MaximAlien changed the title Update to Mapbox Maps v10.0.0-rc.4. Update to Mapbox Maps v10.0.0-rc.4 and Navigation Native v59.0.0. Jul 22, 2021
@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 5 times, most recently from b218c74 to fefe858 Compare July 28, 2021 19:29
@MaximAlien MaximAlien requested a review from a team July 28, 2021 20:26
@MaximAlien MaximAlien marked this pull request as ready for review July 28, 2021 20:27
@MaximAlien MaximAlien changed the title Update to Mapbox Maps v10.0.0-rc.4 and Navigation Native v59.0.0. Update to Mapbox Maps v10.0.0-rc.5 and Navigation Native v60.0.0. Jul 28, 2021
@MaximAlien MaximAlien force-pushed the maxim/update-dependencies branch 2 times, most recently from 96c8c3d to cb5b84f Compare August 2, 2021 16:01
Copy link
Contributor

@jill-cardamon jill-cardamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@jill-cardamon jill-cardamon requested a review from a team August 2, 2021 18:04
@@ -108,15 +108,15 @@ public enum DistancedRoadObject {
let info = native.distanceInfo.getPolygonDistanceInfo()
self = .polygon(identifier: native.roadObjectId,
type: RoadObjectType(native.type),
distanceToNearestEntry: info.distanceToNearestEntry,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant about this change, but to be more defensive I'd rather return an optional value instead of crashing or asserting.

@MaximAlien MaximAlien merged commit a9e6106 into main Aug 2, 2021
@MaximAlien MaximAlien deleted the maxim/update-dependencies branch August 2, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to builds and dependency management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants