Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current location for route refresh #3781

Merged
merged 3 commits into from Mar 11, 2022
Merged

Use current location for route refresh #3781

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
828ccc4
Use current location for route refresh
S2Ler Mar 11, 2022
3a1658a
Add changelog entry
S2Ler Mar 11, 2022
df56f5a
Merge branch 'main' into issue/fix-refresh-route-location
1ec5 Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,5 +1,9 @@
# Changes to the Mapbox Navigation SDK for iOS

## Next

* Fixed an issue where after a route was refreshed the vanishing route line would be incorrectly drawn. ([#3781](https://github.com/mapbox/mapbox-navigation-ios/pull/3781))

## v2.3.0

The v2.2.0 release notes [clarified](https://github.com/mapbox/mapbox-navigation-ios/pull/3652) that is an error to have more than one instance of `NavigationViewController`, `NavigationService`, or `RouteController` running simultaneously. Now you will receive a log message at the fault level helping you to spot the issue. To pause the debugger when the SDK detect the problematic situation, enable the “All Runtime Issues” breakpoint in Xcode. Learn more about breakpoints in [Xcode documentation](https://developer.apple.com/documentation/xcode/setting-breakpoints-to-pause-your-running-app). ([#3740](https://github.com/mapbox/mapbox-navigation-ios/pull/3740))
Expand Down
2 changes: 1 addition & 1 deletion Sources/MapboxCoreNavigation/Router.swift
View file
Open in desktop
Expand Up @@ -246,7 +246,7 @@ extension InternalRouter where Self: Router {
return
}

self.routeProgress.refreshRoute(with: currentRoute, at: location)
self.routeProgress.refreshRoute(with: currentRoute, at: self.location ?? location)

var userInfo = [RouteController.NotificationUserInfoKey: Any]()
userInfo[.routeProgressKey] = self.routeProgress
Expand Down