HistoryRecording instance-based methods #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No breaking changes detected in MapboxCoreNavigation |
Breaking Changes in MapboxNavigationBreaking API Changes
|
| Type of change: | key.doc.result_discussion |
|---|---|
| From: | [["Para": optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
| To: | [["Para": Optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
label(_:willPresent:as:) in InstructionsCardContainerView
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : VisualInstructionDelegate> (Self) -> (InstructionLabel, VisualInstruction, NSAttributedString) -> NSAttributedString? |
| To: | (InstructionsCardContainerView) -> (InstructionLabel, VisualInstruction, NSAttributedString) -> NSAttributedString? |
|
No breaking changes detected in MapboxCoreNavigation |
Breaking Changes in MapboxNavigationBreaking API Changes
|
| Type of change: | key.doc.result_discussion |
|---|---|
| From: | [["Para": optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
| To: | [["Para": Optionally, a customized NSAttributedString that will be presented instead of the default, or if nil, the default behavior will be used.]] |
label(_:willPresent:as:) in InstructionsCardContainerView
| Type of change: | Declaration |
|---|---|
| From: | <Self where Self : VisualInstructionDelegate> (Self) -> (InstructionLabel, VisualInstruction, NSAttributedString) -> NSAttributedString? |
| To: | (InstructionsCardContainerView) -> (InstructionLabel, VisualInstruction, NSAttributedString) -> NSAttributedString? |
… protocol; deprecated static methods.
Udumft
force-pushed
the
vk/3753-history-recording
branch
from
b96206c
to
f4a8da7
Compare
|
No breaking changes detected in MapboxCoreNavigation |
|
No breaking changes detected in MapboxNavigation |
chezzdev
approved these changes
Mar 29, 2022
bamx23
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3753
This PR added instance methods to HistoryRecording protocol, deprecating static methods. Since this protocol is adopted by
RouteControllerandPassiveLocationManager, usage of instance methods insures thatNavigator.sharedexists and history recording will be correct.