Update dependencies for 2.5.0 release #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
commented
Apr 15, 2022
| @@ -33,7 +44,6 @@ | |||
| * Fixed an issue when `SimulatedLocationManager` could freeze the main thread when working with long routes. The manager now calls delegate methods from a background thread. ([#3672](https://github.com/mapbox/mapbox-navigation-ios/pull/3672)) | |||
| * Fixed an issue where initial puck position can be incorrect when `NavigationViewController` is presented. ([#3773](https://github.com/mapbox/mapbox-navigation-ios/pull/3773)) | |||
| * Fixed an issue where `UserHaloCourseView` was not correctly shown while changing `CLLocationManager.accuracyAuthorization` and `CLLocationManager.authorizationStatus`. ([#3804](https://github.com/mapbox/mapbox-navigation-ios/pull/3804)) | |||
| * Fixed an issue where camera was not centered to the current location during `NavigationMapView` initialization. ([#3826](https://github.com/mapbox/mapbox-navigation-ios/pull/3826)) | |||
There was a problem hiding this comment.
wasn't actually released as part of 2.4.0, since this PR was merged after the release branch was cut
azarovalex
commented
Apr 15, 2022
| @@ -36,14 +36,14 @@ class Navigator { | |||
| .init(setRoutesHandler: { [weak self] route, legIndex, completion in | |||
| self?.navigator.setPrimaryRouteForRoute(route, legIndex: legIndex) { [weak self] result in | |||
| if result.isValue() { | |||
| let routeInfo = result.value as! RouteInfo | |||
There was a problem hiding this comment.
NN now exposes actual generics instead of AnyObject, so no need to cast here and in other places
ShanMa1991
approved these changes
Apr 15, 2022
bamx23
reviewed
Apr 15, 2022
bamx23
approved these changes
Apr 15, 2022
MaximAlien
reviewed
Apr 15, 2022
MaximAlien
reviewed
Apr 22, 2022
CHANGELOG.md
Outdated
|
|
||
| ### Packaging | ||
|
|
||
| * MapboxNavigation now requires [MapboxMaps v10.5.0-beta.1](https://github.com/mapbox/mapbox-maps-ios/releases/tag/v10.5.0-rc.1). ([#3834](https://github.com/mapbox/mapbox-navigation-ios/pull/3834)) |
There was a problem hiding this comment.
Suggested change
| * MapboxNavigation now requires [MapboxMaps v10.5.0-beta.1](https://github.com/mapbox/mapbox-maps-ios/releases/tag/v10.5.0-rc.1). ([#3834](https://github.com/mapbox/mapbox-navigation-ios/pull/3834)) | |
| * MapboxNavigation now requires [MapboxMaps v10.5.0-rc.1](https://github.com/mapbox/mapbox-maps-ios/releases/tag/v10.5.0-rc.1). ([#3834](https://github.com/mapbox/mapbox-navigation-ios/pull/3834)) |
There was a problem hiding this comment.
ah missed that. thanks! will fix now.
|
Please also rebase this PR onto main to resolve |
ShanMa1991
reviewed
Apr 22, 2022
Co-authored-by: Maxim Makhun <maxim.makhun@mapbox.com>
jill-cardamon
force-pushed
the
azarovalex/release-2.5.0
branch
from
7c7d324
to
63df4eb
Compare
ShanMa1991
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Common to
v21.3.0-rc.2, Maps to10.5.0-rc.1and NN to97.0.0