Fix LaneView styling on CarPlay.
#3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
added
bug
MaximAlien
commented
Jun 29, 2022
| /** | ||
| Returns hex representation of a `UIColor`. | ||
| */ | ||
| var hexString: String { |
There was a problem hiding this comment.
Added for debugging purposes to simplify detection of color differences.
| let darkImage = darkLanesImage { | ||
| // `CPImageSet` applies `lightContentImage` for dark appearance and `d`arkContentImage` | ||
| // for light appearance, because of this `darkImage` is set for `lightContentImage` parameter. | ||
| return CPImageSet(lightContentImage: darkImage, darkContentImage: lightImage) |
There was a problem hiding this comment.
This looks like a system bug, basically colors are inverted. CPImageSet was also deprecated in iOS 13. I'll create a separate ticket to find a suitable replacement.
ShanMa1991
approved these changes
Jun 30, 2022
MaximAlien
force-pushed
the
maxim/3974-fix-lane-view-styling
branch
from
58d8b74
to
70ae4e2
Compare
…ince it has no effect.
MaximAlien
force-pushed
the
maxim/3974-fix-lane-view-styling
branch
from
215af69
to
6fed0a0
Compare
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes #3974.
CarPlay was using incorrect
LaneViewstyling due to two issues:CPImageSetuseslightContentImagefor dark appearance anddarkContentImagefor light appearance (looks like a system bug).