Add delegates to NavigationViewController.
#4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximAlien
force-pushed
the
maxim/NAVIOS-614-add-delegates-to-navigation-view-controller
branch
from
d4b4cbf
to
ab15b2b
Compare
Breaking Changes in MapboxNavigationBreaking API Changes
|
MaximAlien
commented
Sep 27, 2022
| /** | ||
| `UnimplementedLogging` prints a warning to standard output the first time this method is called. | ||
| */ | ||
| func navigationViewController(_ navigationViewController: NavigationViewController, didSelect route: Route) { |
There was a problem hiding this comment.
Such method is not actually exposed anywhere, can be removed.
There was a problem hiding this comment.
Should we expose it then? Or it is outdated and non existent delegate method?
There was a problem hiding this comment.
I do not think that anybody requested it recently, so we can add it when it's really needed.
Breaking Changes in MapboxNavigationBreaking API Changes
|
Breaking Changes in MapboxNavigationBreaking API Changes
|
S2Ler
approved these changes
Sep 30, 2022
MaximAlien
deleted the
maxim/NAVIOS-614-add-delegates-to-navigation-view-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds delegate methods to
NavigationViewControllerthat allow to detect taps on waypoints and continuous alternatives.